Add docs for Prometheus integration #93
Open
+89
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
still draft? |
Author
|
didn't created the grafana dashboards yet. Also need to document the system/metrics endpoint. But I was waiting for the next dev release to test properly. But we can merge and I'll do follow up PR's when done. |
Author
|
Are the merged changes here instantly visible in the official docs or will they be visible when a new major version is released? |
Contributor
|
the doc is built instantly on every PR. I just released dev-35. no hurry though, was just wondering where it was |
Author
|
Understood. I thought maybe its better to merge with the next major release because the described features here aren't even in the current firmware major version. Or we merge with some hint in the docs that this is only available in the current dev release. What do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds documentation for the Prometheus integration feature added to EMS-ESP32 here:
emsesp/EMS-ESP32#2774
Looking forward to build a example Grafana dashboard using Prometheus metrics that can be referenced in the docs. Drafted this PR until then.